-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2209 Refactor ssize_t to iox_ssize_t for Windows compatibility #2342
iox-#2209 Refactor ssize_t to iox_ssize_t for Windows compatibility #2342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add this to the end of the bugfix section of iceoryx-unreleased.md
ssize_t: redefinition; different basic types [#2209](https://github.com/eclipse-iceoryx/iceoryx/issues/2209)
It also seems that you need to run clang-format on the changed files.
Btw, the git hooks would take care of this. Have a look at tools/git-hooks/Readme.md
@elBoberido fixed |
@elBoberido fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please squash your commits?
b22981d
to
35d6729
Compare
@elBoberido done |
@elBoberido if you return it then it doesn't work on msvc |
I just tried it locally with msvc and also mingw and it worked. I think it was just an intermediate problem. Can you revert that change to see if the CI has an other opinion :) |
@elBoberido canceled the changes |
@elBoberido Error in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2342 +/- ##
==========================================
- Coverage 78.23% 78.22% -0.01%
==========================================
Files 433 433
Lines 16033 16033
Branches 2299 2299
==========================================
- Hits 12543 12542 -1
Misses 2647 2647
- Partials 843 844 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Oh, sorry. I was not precise enough. With revert the changes I actually meant to replace Can you then also please squash the last three commits. |
8b05151
to
14d6e9b
Compare
iox-eclipse-iceoryx#2209 Fix include and change ssize_t to iox_ssize_t
@elBoberido fixed |
@elBoberido done |
Thanks :) |
This change updates the ssize_t type to iox_ssize_t in Windows-specific files to resolve a compatibility issue. It ensures consistent type usage and includes the necessary headers for type definitions.
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References
@elBoberido I don't have windows to check the build :(