Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2266 Removed warning set but not used #2265

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented Apr 17, 2024

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff
Copy link
Contributor

@ahcorde Thank you for the fix!
Could you please adjust your commit message and add the prefix iox-#2266 (it links to the issue I created for your fix.)

You can do this by

git commit --amend
# add iox-#2266 in front of your commit message
git push -f

The background is that we are a project that also runs on a safety-critical system, and therefore, we need to trace every commit message to a GitHub issue.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (c36b875) to head (13a38b5).
Report is 5 commits behind head on release_2.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2265      +/-   ##
===============================================
+ Coverage        78.42%   78.47%   +0.05%     
===============================================
  Files              370      370              
  Lines            14220    14218       -2     
  Branches          2061     2061              
===============================================
+ Hits             11152    11158       +6     
+ Misses            2383     2377       -6     
+ Partials           685      683       -2     
Flag Coverage Δ
unittests 77.71% <ø> (+0.05%) ⬆️
unittests_timing 15.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...posh/source/gateway/toml_gateway_config_parser.cpp 90.90% <ø> (-0.32%) ⬇️

... and 4 files with indirect coverage changes

@ahcorde ahcorde force-pushed the ahcorde/rolling/warning_unused_var branch from ef69360 to 13a38b5 Compare April 19, 2024 14:19
@ahcorde ahcorde changed the title Removed warning set but not used iox-#2266 Removed warning set but not used Apr 19, 2024
@ahcorde
Copy link
Author

ahcorde commented Apr 19, 2024

Done @elfenpiff

@elBoberido elBoberido merged commit 63db532 into eclipse-iceoryx:release_2.0 Apr 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants