Iox #160 optional and expected adjustments #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to and_then and on_error to or_else and deprecated the previous methods Signed-off-by: Christian Eltzschig <[email protected]>
…r or on_success Signed-off-by: Christian Eltzschig <[email protected]>
…on client Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Eltzschig Christian (CC-AD/ESW1) <[email protected]>
FerdinandSpitzschnueffler
previously approved these changes
Jul 8, 2020
mossmaurice
requested changes
Jul 8, 2020
There was a problem hiding this comment.
Please remove the file tools/introspection/COLOCON_IGNORE as discussed with @Karsten1987. Instead we need a mechanism for colcon to ignore the introspection on macOS.
mossmaurice
approved these changes
Jul 8, 2020
budrus
approved these changes
Jul 8, 2020
| // this needs to be properly fixed by harmonizing the types across the functions, but currently this cast is also sufficient | ||
| getMembers()->m_queue.setCapacity(static_cast<decltype(MemberType_t::MAX_CAPACITY)>(newCapacity)); | ||
| // this needs to be properly fixed by harmonizing the types across the functions, but currently this cast is also | ||
| // sufficient |
|
How about the evaluation of expected and optional costs @elfenpiff @elBoberido? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
Fixes #175