Iox #171 roudi message queue thread startup #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kroenke Dietrich (CC-AD/ESW1) <[email protected]>
… initialized after destroy or move Signed-off-by: Kroenke Dietrich (CC-AD/ESW1) <[email protected]>
|
No description ? |
orecham
reviewed
Jul 6, 2020
| RouDiMultiProcess& operator=(const RouDiMultiProcess& other) = delete; | ||
| RouDiMultiProcess(const RouDiMultiProcess& other) = delete; | ||
|
|
||
| RouDiMultiProcess(RouDiMemoryInterface& roudiMemoryInteface, | ||
| PortManager& portManager, | ||
| const MonitoringMode f_monitoringMode = MonitoringMode::ON, | ||
| const bool f_killProcessesInDestructor = true); | ||
| const bool f_killProcessesInDestructor = true, |
There was a problem hiding this comment.
Very minor but the variable is inconsistent with the .cpp.
killProcessesInDestructor vs f_killProcessesInDestructor.
orecham
reviewed
Jul 6, 2020
| // this is important for derived classes which may need to initialize their members before the thread starts | ||
| enum class MQThreadMode { | ||
| START, | ||
| DEFER_START |
There was a problem hiding this comment.
This option seems redundant since the deferred start is not managed by this class. Could we get away with just the one option?
I would also suggest a slightly more descriptive name like:
enum class MQThreadMode {
IMMEDIATE_START
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.