Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1547 Remove GitHub Caching from Bazel build in CI #1550

Merged

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Jul 29, 2022

Signed-off-by: Dietrich Krönke [email protected]

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@dkroenke dkroenke added the bugfix Solves a bug label Jul 29, 2022
@dkroenke dkroenke self-assigned this Jul 29, 2022
@dkroenke dkroenke force-pushed the iox-1547-fix-bazel-build-in-CI branch 2 times, most recently from e15767f to 57cc237 Compare July 29, 2022 14:56
Exclude Thread_test in hoofs from GitHub CI Bazel
@dkroenke dkroenke force-pushed the iox-1547-fix-bazel-build-in-CI branch from 57cc237 to 0078ff0 Compare July 29, 2022 14:58
@dkroenke dkroenke marked this pull request as ready for review July 29, 2022 15:00
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1550 (0078ff0) into master (2c6827c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
- Coverage   78.89%   78.87%   -0.03%     
==========================================
  Files         379      379              
  Lines       14487    14487              
  Branches     2028     2028              
==========================================
- Hits        11430    11426       -4     
- Misses       2431     2433       +2     
- Partials      626      628       +2     
Flag Coverage Δ
unittests 78.53% <ø> (-0.03%) ⬇️
unittests_timing 14.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-11.43%) ⬇️

Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@dkroenke dkroenke merged commit 7713e14 into eclipse-iceoryx:master Aug 1, 2022
@dkroenke dkroenke deleted the iox-1547-fix-bazel-build-in-CI branch August 1, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional Bazel support
3 participants