-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
empty PREFIX leads to wrong path in INTERFACE_INCLUDE_DIRECTORIES on CMake #1481
Labels
bug
Something isn't working
Comments
dkroenke
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 11, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 11, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 11, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
This was referenced Jul 11, 2022
dkroenke
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 13, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 13, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 14, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 14, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
21 tasks
dkroenke
added a commit
that referenced
this issue
Jul 14, 2022
…e-include-directories-cmake iox-#1481 Fix interface include directories in CMake
elBoberido
pushed a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 14, 2022
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
added a commit
that referenced
this issue
Jul 15, 2022
…e-include-directories-cmake-release_2.0 iox-#1481 Set PREFIX in CMake directly [release_2.0]
25 tasks
21 tasks
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Required information
Operating system:
E.g. Ubuntu 22.04
CMake version:
CMake 3.22.1
Observed result or behaviour:
The
INTERFACE_INCLUDE_DIRECTORIES
defined in the generatediceoryx_poshTargets.cmake
file contains invalid directory set to
${_IMPORT_PREFIX}/include//iceoryx/v2.90.0
.This affects all iceoryx packages.
When an external application tries to use the
INTERFACE_INCLUDE_DIRECTORIES
property,the includes cannot be found.
test code in iceoryx example:
output in out-of-tree build:
Expected result or behaviour:
INTERFACE_INCLUDE_DIRECTORIES evaluates always to a valid directory
with set/unset PREFIX variable.
Conditions where it occurred / Performed steps:
The reason lies in this code snippet:
The
PREFIX
expression evaluates here always to false even when the variableis not set which is the case in iceoryx.
This leads to an attached
/
characterin the install include directories.
The generated include directory seems not to be affected by this.
Solution could be to evaluate the actual content of the Variable:
FYI @sloretz
The text was updated successfully, but these errors were encountered: