Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve configuration for remaining provider proxies #54

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Improve configuration for remaining provider proxies #54

merged 6 commits into from
Sep 29, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Sep 29, 2023 •
edited
Loading

Includes the following changes:

  • Improves configuration and adds overrides for other (non-GRPC) provider proxies
  • Improves the config strategy overall with some things moved to common places
  • Minor fix: removes an unnecessary Arc usage in the provider proxies

Part of #17

@github-actions
Copy link
Contributor

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

ashbeitz
ashbeitz reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Please take a look.

mapping_clients/in_memory_mock_mapping_client/README.md Outdated Show resolved Hide resolved
mapping_clients/in_memory_mock_mapping_client/README.md Outdated Show resolved Hide resolved
provider_proxies/in_memory_mock_provider_proxy/README.md Outdated Show resolved Hide resolved
ashbeitz
ashbeitz approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@wilyle wilyle merged commit 4dac9b1 into main Sep 29, 2023
14 checks passed
@wilyle wilyle deleted the wilyle/more-proxy-config branch September 29, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashbeitz ashbeitz ashbeitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilyle @ashbeitz