Easier runtime config for mapping mocks and remove unnecessary mock cloud adapter config #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
ashbeitz
reviewed
Sep 27, 2023
mapping_clients/in_memory_mock_mapping_client/src/in_memory_mock_mapping_client.rs
Outdated
Show resolved
Hide resolved
jorchiu
reviewed
Sep 27, 2023
jorchiu
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to configure the mapping mocks (both in-memory and external) at runtime with layered configuration files. Also removes the mock cloud adapter config which was not used.
This addresses two of the tasks in #17, but more work is needed before that can be closed. This PR should serve as a precedent for the remaining work.