-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cartographer + Emitter Reimplementation #43
Conversation
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comments. All are minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Reimplements the cartographer and emitter. Changes include:
Box<dyn Trait>
to generics for pluggable componentsDigitalTwinAdapter::find_by_id
call to the cartographer, thereby eliminating the need for digital twin adapters to run a separate threadResult
instead of panickingmockall
for emitter tests instead of the in-memory mockThis partially addresses #18, but more work is needed to get provider proxies integrated