Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartographer + Emitter Reimplementation #43

Merged
merged 21 commits into from
Sep 6, 2023
Merged

Cartographer + Emitter Reimplementation #43

merged 21 commits into from
Sep 6, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Sep 1, 2023

Reimplements the cartographer and emitter. Changes include:

  • Switch from Box<dyn Trait> to generics for pluggable components
  • Use a single shared signal store rather than separate shared components between each interface combo
  • Move the DigitalTwinAdapter::find_by_id call to the cartographer, thereby eliminating the need for digital twin adapters to run a separate thread
  • Update the API for providers and the provider proxy to use struct-like enum variants and return Result instead of panicking
  • Utilize mockall for emitter tests instead of the in-memory mock
  • Prevent errors on one signal in the cartographer and emitter from taking down the entire app
  • Misc minor cleanup

This partially addresses #18, but more work is needed to get provider proxies integrated

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

freyja/src/cartographer.rs Fixed Show fixed Hide fixed
freyja/src/cartographer.rs Fixed Show fixed Hide fixed
freyja/src/cartographer.rs Fixed Show fixed Hide fixed
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments. All are minor.

freyja/src/cartographer.rs Outdated Show resolved Hide resolved
freyja/src/cartographer.rs Outdated Show resolved Hide resolved
freyja/src/cartographer.rs Show resolved Hide resolved
freyja/src/cartographer.rs Outdated Show resolved Hide resolved
freyja/src/cartographer.rs Show resolved Hide resolved
freyja/src/cartographer.rs Show resolved Hide resolved
common/src/signal_store.rs Outdated Show resolved Hide resolved
freyja/src/emitter.rs Show resolved Hide resolved
freyja/src/emitter.rs Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@wilyle wilyle merged commit b38d4e4 into main Sep 6, 2023
14 checks passed
@wilyle wilyle deleted the wilyle/shared branch September 12, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants