Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plantuml generation workflow #117

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Update plantuml generation workflow #117

merged 6 commits into from
Jan 23, 2024

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Jan 23, 2024

Updates the plantuml generation workflow so that it can use the eclipse-ibeji-bot as the committer. The previous version of the workflow could only use the github-actions-bot as the committer, which does not have a signed ECA and will fail workflow validation.

Note that the diagrams were regenerated and have a different style, likely because the settings being used during generation by the previous workflow were not the defaults.

Addresses one of the tasks in #112

Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Please fix.

.github/workflows/generate-plantuml.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wilyle wilyle merged commit 47498bc into main Jan 23, 2024
10 checks passed
@wilyle wilyle deleted the wilyle/plantuml branch January 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants