custom mapper should not always return a 503 when the mapping fails #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophokles73
requested changes
Jan 24, 2024
Comment on lines
286
to
302
| private Throwable mapException(final AsyncResult<HttpResponse<Buffer>> httpResponseAsyncResult) { | ||
| final Optional<HttpResponse<Buffer>> httpResponse = Optional.ofNullable(httpResponseAsyncResult.result()); | ||
| final int statusCode = httpResponse.map(HttpResponse::statusCode).orElse(HttpURLConnection.HTTP_INTERNAL_ERROR); | ||
| if (statusCode >= 400 && statusCode < 500) { | ||
| return new ClientErrorException(statusCode, httpResponseAsyncResult.cause()); | ||
| } | ||
| return new ServerErrorException(statusCode, httpResponseAsyncResult.cause()); | ||
| } | ||
|
|
||
| private Throwable mapException(final AsyncResult<HttpResponse<Buffer>> httpResponseAsyncResult, final String message) { | ||
| final Optional<HttpResponse<Buffer>> httpResponse = Optional.ofNullable(httpResponseAsyncResult.result()); | ||
| final int statusCode = httpResponse.map(HttpResponse::statusCode).orElse(HttpURLConnection.HTTP_INTERNAL_ERROR); | ||
| if (statusCode >= 400 && statusCode < 500) { | ||
| return new ClientErrorException(statusCode, message); | ||
| } | ||
| return new ServerErrorException(statusCode, message); | ||
| } |
There was a problem hiding this comment.
can we reduce the code duplication by e.g. having just one method which accepts an Optional<String> message?
There was a problem hiding this comment.
you might also want to consider using org.eclipse.hono.client.util.StatusCodeMapper.from() to create a context specific ServiceInvocationException ...
There was a problem hiding this comment.
sure, now it uses the StatusCodeMapper.
.../mqtt-base/src/test/java/org/eclipse/hono/adapter/mqtt/impl/HttpBasedMessageMappingTest.java
Show resolved
Hide resolved
sophokles73
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3609