[#3555] Device Registry JDBC native build #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophokles73
reviewed
Dec 19, 2023
Comment on lines
4
to
14
| { "pattern": "org\\/eclipse\\/hono\\/service\\/base\\/jdbc\\/store\\/devcon\\/base.h2.sql.yaml" }, | ||
| { "pattern": "org\\/eclipse\\/hono\\/service\\/base\\/jdbc\\/store\\/devcon\\/base.postgresql.sql.yaml" }, | ||
| { "pattern": "org\\/eclipse\\/hono\\/service\\/base\\/jdbc\\/store\\/devcon\\/base.sql.yaml" }, | ||
| { "pattern": "org\\/eclipse\\/hono\\/service\\/base\\/jdbc\\/store\\/device\\/base.h2.sql.yaml" }, | ||
| { "pattern": "org\\/eclipse\\/hono\\/service\\/base\\/jdbc\\/store\\/device\\/base.postgresql.sql.yaml" }, | ||
| { "pattern": "org\\/eclipse\\/hono\\/service\\/base\\/jdbc\\/store\\/device\\/base.sql.yaml" }, | ||
| { "pattern": "org\\/eclipse\\/hono\\/service\\/base\\/jdbc\\/store\\/tenant\\/base.sql.yaml" }, | ||
| { "pattern": "sql\\/h2\\/01-create.tenants.sql" }, | ||
| { "pattern": "sql\\/h2\\/02-create.devices.sql" }, | ||
| { "pattern": "sql\\/postgresql\\/01-create.tenants.sql" }, | ||
| { "pattern": "sql\\/postgresql\\/02-create.devices.sql" } |
There was a problem hiding this comment.
maybe we can make these more generic, e.g. using wildcards that expand to all yaml and sql files?
There was a problem hiding this comment.
Done, I kept some base resource directory structure under which *.yaml and *.sql files are filtered in.
| @@ -47,17 +47,19 @@ jobs: | |||
| -Pbuild-native-image,metrics-prometheus -am \ | |||
| -pl :hono-service-auth,:hono-service-command-router,:hono-service-device-registry-mongodb,\ | |||
| :hono-adapter-mqtt,:hono-adapter-amqp,:hono-adapter-coap,:hono-adapter-http,:hono-adapter-lora,\ | |||
| :hono-tests | |||
| :hono-tests,:hono-service-device-registry-jdbc | |||
There was a problem hiding this comment.
would you mind putting this after :hono-service-device-registry-mongodb?
sophokles73
added
enhancement
JDBC Device Registry
sophokles73
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for device registry JDBC to make native-image build succeeds and native-image integration tests run passes.