Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering for gateway or edge devices only #3591

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

sophokles73
Copy link
Contributor

This addresses #3517

The MongoDB based registry has been extended to support the isGateway
query parameter of the Registry Management API's search devices
operation.

@sophokles73 sophokles73 added Feature Request A request for adding new functionality to Hono MongoDB Device Registry issues related to the Device Registry implementation based on MongoDB labels Dec 3, 2023
@sophokles73 sophokles73 added this to the 2.5.0 milestone Dec 3, 2023
@sophokles73 sophokles73 requested a review from kaniyan as a code owner December 3, 2023 15:43
@sophokles73 sophokles73 marked this pull request as draft December 3, 2023 17:36
@sophokles73 sophokles73 force-pushed the implement_gateway_filter_for_mongo_registry branch 5 times, most recently from 3263d79 to 84204e0 Compare December 17, 2023 15:36
@sophokles73 sophokles73 marked this pull request as ready for review December 17, 2023 16:00
@sophokles73 sophokles73 force-pushed the implement_gateway_filter_for_mongo_registry branch from 84204e0 to e9b9481 Compare December 17, 2023 16:05
@sophokles73 sophokles73 requested review from calohmn and removed request for kaniyan December 19, 2023 06:42
@sophokles73
Copy link
Contributor Author

@calohmn would you mind taking a look?

@sophokles73 sophokles73 force-pushed the implement_gateway_filter_for_mongo_registry branch from e9b9481 to 70e77fa Compare January 15, 2024 07:20
@sophokles73
Copy link
Contributor Author

@calohmn would you mind taking another (final) look?

Copy link
Contributor

@calohmn calohmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The MongoDB based registry has been extended to support the isGateway
query parameter of the Registry Management API's search devices
operation.
@sophokles73 sophokles73 force-pushed the implement_gateway_filter_for_mongo_registry branch from 70e77fa to 12c9c7b Compare January 15, 2024 17:51
@sophokles73 sophokles73 merged commit fe89a48 into master Jan 15, 2024
10 checks passed
@sophokles73 sophokles73 deleted the implement_gateway_filter_for_mongo_registry branch January 15, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A request for adding new functionality to Hono MongoDB Device Registry issues related to the Device Registry implementation based on MongoDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants