Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Pub/Sub getOrCreateTopic and getOrCreateSubscription flow #3549

Closed
mattkaem opened this issue Sep 25, 2023 · 0 comments · Fixed by #3550
Closed

Improve Pub/Sub getOrCreateTopic and getOrCreateSubscription flow #3549

mattkaem opened this issue Sep 25, 2023 · 0 comments · Fixed by #3550
Assignees
@mattkaem
Labels
C&C Command and Control enhancement
Milestone
2.5.0

Comments

@mattkaem
Copy link
Contributor

Currently when trying to get or create a Pub/Sub topic/subscription we try to create the topic/subscription first and only if this fails with a AlreadyExistsException we try to get the topic/subscription. This is very inefficient for cases where the topic/subscription exists already. Instead I want to improve this so we try to get the topic/subscription first and only if this fails we try to create it.
@mattkaem mattkaem self-assigned this Sep 25, 2023
mattkaem added a commit to sotec-iot/hono that referenced this issue Sep 25, 2023
@mattkaem
[eclipse-hono#3549] Improved getOrCreateTopic/Subscription flow for P…
431cf59 
…ub/Sub messaging infrastructure and changed the subscription expiration to never

Signed-off-by: Matthias Kaemmer <[email protected]>
@sophokles73 sophokles73 added enhancement C&C Command and Control labels Sep 25, 2023
@sophokles73 sophokles73 added this to the 2.5.0 milestone Sep 25, 2023
mattkaem added a commit to sotec-iot/hono that referenced this issue Sep 27, 2023
@mattkaem
[eclipse-hono#3549] Improved getOrCreateTopic/Subscription flow for P…
f3c0f2b 
…ub/Sub messaging infrastructure and changed the subscription expiration to never

Signed-off-by: Matthias Kaemmer <[email protected]>
mattkaem added a commit to sotec-iot/hono that referenced this issue Oct 27, 2023
@mattkaem
[eclipse-hono#3549] Improved getOrCreateTopic/Subscription flow for P…
5a88ede 
…ub/Sub messaging infrastructure and changed the subscription expiration to never

Signed-off-by: Matthias Kaemmer <[email protected]>
mattkaem added a commit to sotec-iot/hono that referenced this issue Nov 2, 2023
@mattkaem
[eclipse-hono#3549] Improved getOrCreateTopic/Subscription flow for P…
0561fa0 
…ub/Sub messaging infrastructure and changed the subscription expiration to never

Signed-off-by: Matthias Kaemmer <[email protected]>
mattkaem added a commit that referenced this issue Nov 2, 2023
@mattkaem
[#3549] Improved getOrCreateTopic/Subscription flow for Pub/Sub messa…
28475fa 
…ging infrastructure and changed the subscription expiration to never

Signed-off-by: Matthias Kaemmer <[email protected]>
@mattkaem mattkaem linked a pull request Nov 2, 2023 that will close this issue
[#3549] Improved getOrCreateTopic/Subscription flow for Pub/Sub #3550
Merged
@mattkaem mattkaem closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkaem mattkaem

Labels
C&C Command and Control enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

[#3549] Improved getOrCreateTopic/Subscription flow for Pub/Sub sotec-iot/hono
2 participants
@sophokles73 @mattkaem