Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP request tracing: only set span names according to known routes #3266

Closed
calohmn opened this issue May 19, 2022 · 0 comments · Fixed by #3270
Closed

HTTP request tracing: only set span names according to known routes #3266

calohmn opened this issue May 19, 2022 · 0 comments · Fixed by #3270
Assignees
@calohmn
Labels
bug Device Registry HTTP Adapter
Milestone
2.0.0

Comments

@calohmn
Copy link
Contributor

calohmn commented May 19, 2022

When making HTTP requests with random (invalid) paths to the HTTP adapter or device registry, these paths will be used as span names for the HTTP request traces.
This will pollute the "operation" combo-box in the Jaeger UI with these names.

This was introduced by the changes made for #3213.
@calohmn calohmn added this to the 2.0.0 milestone May 19, 2022
@calohmn calohmn self-assigned this May 19, 2022
calohmn added a commit to bosch-io/hono that referenced this issue May 20, 2022
@calohmn
[eclipse-hono#3266] Fix HTTP request span names.
9922bf8 
HTTP requests for which no specific route matches
shall get a fixed tracing span name, not one
corresponding to the request path.

Signed-off-by: Carsten Lohmann <[email protected]>
@calohmn calohmn mentioned this issue May 20, 2022
Merged
calohmn added a commit that referenced this issue May 20, 2022
@calohmn
[#3266] Fix HTTP request span names.
491e2f6 
HTTP requests for which no specific route matches
shall get a fixed tracing span name, not one
corresponding to the request path.

Signed-off-by: Carsten Lohmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calohmn calohmn

Labels
bug Device Registry HTTP Adapter
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[#3266] Fix HTTP request span names bosch-io/hono
1 participant
@calohmn