-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'vertx', 'quarkus' from module/image names #3092
Comments
If we want to rename the images then I would suggest to indeed also drop the |
So, the adapter image names then are:
while we basically keep the service image names:
Or am I mistaken? @calohmn |
@sophokles73 Why wouldn't we remove the |
well, for example the hono-service-auth image name has been used for the |
Yes, I think it's about whether and how we support using the newest (2.0) Hono Helm chart with Hono 1.x images. I think keeping support for Hono 1.x images would require keeping some 1.x-only logic in the Hono Helm chart, namely support for SpringBoot images and usage of the Jaeger agent sidecar container (instead of the OpenTelemetry Collector sidecar container for Hono 2.0). On the other hand, users wanting to keep using Hono 1.x images could just stick to the current 1.x Helm chart version, using the In any case, changing the service image names here as well wouldn't matter much concerning the chart changes, I guess. If we keep Hono 1.x image support, explicit 1.x related parameters (or 1.x-version parsing of the |
I would rather get rid of all of the deprecated stuff and have a clean 2.0.0 based chart. As you pointed out, users who want to stick to Hono 1.x can still use the 1.x based chart. FMPOV we should strip out everything that is no longer supported in Hono 2.0.0 from the chart as well. |
I have created an issue with Eclipse Webmasters to create the corresponding repositories on Docker Hub. |
Dropping the "-vertx-quarkus" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-vertx-quarkus" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
I think the CLI module name and created jar could be renamed as well (from |
Dropping the "-vertx-quarkus" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-quarkus" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-quarkus" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-vertx" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-vertx" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-quarkus" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-quarkus" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Dropping the "-vertx" suffix. Signed-off-by: Carsten Lohmann <[email protected]>
Signed-off-by: Carsten Lohmann <[email protected]>
@calohmn anything else to be done here? |
Should we keep the |
IMHO we should keep them because they help us to apply the build-docker-image and build-native-image profiles to the service implementation modules only (and not to the base class modules). |
However, we could remove the |
Naming is a bit tricky then, though. We currently have
Renaming |
Signed-off-by: Carsten Lohmann <[email protected]>
Signed-off-by: Carsten Lohmann <[email protected]>
With spring boot variants removed (#3090) the adapter maven module and image names can be shortened. I guess the "vertx" part can be removed as well.
E.g. renaming
hono-adapter-amqp-vertx-quarkus
tohono-adapter-amqp
.The text was updated successfully, but these errors were encountered: