Add portRequest url handler property #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkbit-bot
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Thanks @flobz for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution.
Please make sure you read the contribution guide and signed the Eclipse Contributor Agreement (ECA).
|
Can one of the admins verify this patch? |
The option server.forward-headers-strategy=NATIVE allow to dynamicly generate link based on X-Forwarded-Proto header. Unfortunately Hawkbit artifact use a custom url handler. This PR allow to serve artifacts on http and https in the same time. Signed-off-by: Florian Bezannier <[email protected]>
flobz
force-pushed
the
portRequest_url_handeler
branch
from
e10ae7a to
3ab5d5c
Compare
avgustinmm
requested changes
Oct 18, 2023
avgustinmm
approved these changes
Oct 19, 2023
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
server.forward-headers-strategy=NATIVEallow to dynamicly generate link based on X-Forwarded-Proto header.Unfortunately Hawkbit artifact use a custom url handler. This PR allow to serve artifacts behind a reverse proxy on http and https in the same time.