Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency to sprotty-theia can not be resolved without yarn resolutions #757

Closed
tortmayr opened this issue Oct 3, 2022 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#138
Closed

Dependency to sprotty-theia can not be resolved without yarn resolutions #757

tortmayr opened this issue Oct 3, 2022 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#138
Assignees
@tortmayr
Labels
bug Something isn't working theia

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Oct 3, 2022

Sprotty-theia declares its Theia dependencies in a fluent fashion (e.g. ^1.27.0). This makes it impossible for adopting projects (like GLSP) to use a fixed Theia version that is different from the current latest Theia Version. And as soon as new Theia version is released the build might break.
Same is also true for the sprotty dependency. If the version used by the glsp-client is not compatible with sprotty-theia we have to use resolutions.

We should evaluate whether its possible to switch the sprotty-theia dependencies to peer dependencies and/or in the long run we could also consider to drop sprotty-theia entirely.
@tortmayr tortmayr added bug Something isn't working theia labels Oct 3, 2022
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Oct 3, 2022
@tortmayr
Update to Theia Community Release (1.29.1)
eb75bc6 
- Update Theia dependencies to the community release (1.29.1)
- Use yarn resolutions to ensure stable Theia and sprotty versions and fix upgrade:next script (eclipse-glsp/glsp#757) 
- Update minimum version constraint to node 14 (eclipse-glsp/glsp#676)
- Update lerna version (eclipse-glsp/glsp#680)
- Regenerate yarn.lock

Part of eclipse-glsp/glsp#680
Part of eclipse-glsp/glsp#676
@tortmayr tortmayr mentioned this issue Oct 3, 2022
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Oct 3, 2022
@tortmayr
Update to Theia Community Release (1.29.1) (#131)
0b5e8b5 
- Update Theia dependencies to the community release (1.29.1)
- Use yarn resolutions to ensure stable Theia and sprotty versions and fix upgrade:next script (eclipse-glsp/glsp#757) 
- Update minimum version constraint to node 14 (eclipse-glsp/glsp#676)
- Update lerna version (eclipse-glsp/glsp#680)
- Regenerate yarn.lock

Part of eclipse-glsp/glsp#680
Part of eclipse-glsp/glsp#676
@tortmayr tortmayr self-assigned this Dec 11, 2022
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Dec 20, 2022
@tortmayr
[WIP] Switch theia extensions to peer depdendencies
0fcb42e 
Fixes eclipse-glsp/glsp#535
Fixes eclipse-glsp/glsp#757
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Dec 21, 2022
@tortmayr
Switch theia extensions to peer depdendencies
5024da3 
Fixes eclipse-glsp/glsp#535
Fixes eclipse-glsp/glsp#757
Contributed on behalf of STMicroelectronics
@tortmayr tortmayr mentioned this issue Dec 21, 2022
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Dec 21, 2022
@tortmayr
Switch theia extensions to peer depdendencies
955572e 
Fixes eclipse-glsp/glsp#535
Fixes eclipse-glsp/glsp#757
Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Dec 28, 2022
@tortmayr
Switch theia extensions to peer dependencies (#138)
eeaba3f 
Fixes eclipse-glsp/glsp#535
Fixes eclipse-glsp/glsp#757

Co-authored-by: Philip Langer <[email protected]>
Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
bug Something isn't working theia
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch theia extensions to peer dependencies eclipse-glsp/glsp-theia-integration
1 participant
@tortmayr