Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Interface usage across *Manager classes #1393

Closed
ndoschek opened this issue Aug 21, 2024 · 0 comments · Fixed by eclipse-glsp/glsp-client#388
Closed

Align Interface usage across *Manager classes #1393

ndoschek opened this issue Aug 21, 2024 · 0 comments · Fixed by eclipse-glsp/glsp-client#388
Assignees
@ndoschek
Labels
client enhancement New feature or request

Comments

@ndoschek
Copy link
Contributor

Follow-up of eclipse-glsp/glsp-client#385

There is an inconsistency in how manager classes are bound, with some using the interface+symbol combination (e.g., IHelperLineManager, IToolManager) and others directly injecting the class (e.g., ChangeBoundsManager and GridManager).

This issue aims to align the remaining *Manager classes to ensure consistent usage of interfaces and bindings.
This will involve reviewing the current implementations and making necessary adjustments to follow a consistent pattern across all manager classes.
Ensure to maintain backward compatibility by using the bindAsService helper method.
@ndoschek ndoschek added enhancement New feature or request client labels Aug 21, 2024
@ndoschek ndoschek mentioned this issue Aug 21, 2024
Merged
2 tasks
@ndoschek ndoschek self-assigned this Aug 22, 2024
ndoschek added a commit to eclipse-glsp/glsp-client that referenced this issue Aug 23, 2024
@ndoschek
GLSP-1393 Align Interface usage across *Manager classes
425e9b0 
- Align interface + symbol usage for *Manager classes
- Use bindAsService to ensure backward compatibility
- Update injects to use the symbol instead of the actual manager class

Resolves eclipse-glsp/glsp#1393
ndoschek added a commit to eclipse-glsp/glsp-client that referenced this issue Aug 23, 2024
@ndoschek
GLSP-1393 Align Interface usage across *Manager classes
6ff6dfb 
- Align interface + symbol usage for *Manager classes
  - `ChangeBoundsManager`, `GridManager`, `DebugManager`
- Use bindAsService to ensure backward compatibility
- Update injects to use the symbol instead of the actual manager class

Resolves eclipse-glsp/glsp#1393
@ndoschek ndoschek mentioned this issue Aug 23, 2024
Merged
2 tasks
@ndoschek ndoschek mentioned this issue Sep 4, 2024
Open
ndoschek added a commit to eclipse-glsp/glsp-client that referenced this issue Sep 4, 2024
@ndoschek
GLSP-1393 Align Interface usage across *Manager classes
335a49f 
- Align interface + symbol usage for *Manager classes
  - `ChangeBoundsManager`, `GridManager`, `DebugManager`
- Use bindAsService to ensure backward compatibility
- Update injects to use the interface instead of the actual manager class

Resolves eclipse-glsp/glsp#1393
@ivy-lli ivy-lli mentioned this issue Oct 21, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndoschek ndoschek

Labels
client enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GLSP-1393 Align Interface usage across *Manager classes eclipse-glsp/glsp-client
1 participant
@ndoschek