-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest client changes #62
Conversation
- Update glsp next dependencies - Use debuggable feature ids for all vscode feature modules - Fix bug with `vscodeNavigationModule` that accidently reused the feature id from the navigation module instead of requiring it - Adjust tool palette css - Customize css for newly introduced features - Ensure that `GLSPProjectionView` is properly rendered - disable overflow of root div - Add mouse listeners to diagram widget to only show projections bars when the diagram is focused - Update example1.wf - Fix title menu contributions. Vscode now requires an icon to render them properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me and works well besides that I have some issues with the navigation and showing of the documentation. Maybe it is something on my side (see inline comment). As soon as I figure out what that could be, this can be merged. Thank you for the good work, Tobias!
- Fix "goToPreviousNode" command definition - Ensure that diagram widget focus state changes are forwarded to the GLSP FocusTracker
Thanks for the review
Fixed
Nice catch. Should be fixed with eclipse-glsp/glsp-server-node#89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but I already wasted an unreasonable amount of time trying to fix that. I guess the only way to fix this would to change the command names to enforce correct lexicographical ordering. But that would be a breaking change which seems a bit overkill for that. |
Interesting, yeah, then let's leave it as it is for now. Thank you! |
What it does
vscodeNavigationModule
that accidently reused the feature id from the navigation module instead of requiring itGLSPProjectionView
is properly renderedHow to test
Follow-ups
Changelog