Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust server startup to use autoassigned ports #33

Merged
merged 1 commit into from
May 4, 2023

Conversation

xai
Copy link
Member

@xai xai commented Apr 5, 2023

All our GLSP server implementations are now capable of port autoassignment. The listening port is printed to STDOUT when the server is launched and has to be parsed by clients.

This patch adjusts the vscode integration to use the new port autoassignment.

Part of eclipse-glsp/glsp/issues/965

All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the vscode integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit 7c749d4 into eclipse-glsp:master May 4, 2023
hege088 pushed a commit to hege088/glsp-vscode-integration that referenced this pull request Feb 2, 2024
All our GLSP server implementations are now capable of port
autoassignment. The listening port is printed to STDOUT when the server
is launched and has to be parsed by clients.

This patch adjusts the vscode integration to use the new port
autoassignment.

Part of eclipse-glsp/glsp/issues/965

Signed-off-by: Olaf Lessenich <[email protected]>

(cherry picked from commit 7c749d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants