Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#783 Fix navigation & update to latest glsp client nighly #28

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Nov 12, 2022

Upgrade yarn lock to consume latest glsp client version. (to consume eclipse-glsp/glsp-client@4a5a0ee)

Refactor server download script (analog to eclipse-glsp/glsp-client#194)
Use yarn resolutions to resolve sprotty version conflict (caused by upstream sprotty-vscode-webview)

Re-add missing registration of the editorSelectedElementsAmount context key
Fixes eclipse-glsp/glsp/issues/783
Fixes eclipse-glsp/glsp/issues/782

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr changed the title Update to latest glsp client nighly #783 Fix navigation & update to latest glsp client nighly Nov 14, 2022
Upgrade yarn lock to consume latest glsp client version. (to consume eclipse-glsp/glsp-client@4a5a0ee)

Refactor server download script (analog to eclipse-glsp/glsp-client#194)
Use yarn resolutions to resolve sprotty version conflict (caused by upstream sprotty-vscode-webview)

Re-add missing registration of the editorSelectedElementsAmount context key
Fixes eclipse-glsp/glsp/issues/783
Fixes eclipse-glsp/glsp/issues/782
@tortmayr tortmayr merged commit 151c3c1 into master Nov 14, 2022
@tortmayr tortmayr deleted the housekeeping branch June 17, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants