Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1320: Update to latest glsp dev config #206

Merged
merged 2 commits into from
May 15, 2024
Merged

GLSP-1320: Update to latest glsp dev config #206

merged 2 commits into from
May 15, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented May 14, 2024

What it does

  • Updates to latest version of dev,client & server packages
  • Add temporary resolution
  • Add generate:index utility script
  • Regenerate index files
  • Fix codeActionsOnSave in vscode settings
  • Refactor upgrade:next script
  • Reformat code base with prettier
  • Fix copyright headers (by running a full check with glsp checkHeaders . -t full)

Requires: eclipse-glsp/glsp-client#345
Part of eclipse-glsp/glsp#1320

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Updates to latest version of dev,client & server packages
- Add temporary resolution 
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)

Part of eclipse-glsp/glsp#1320
@martin-fleck-at
Copy link
Contributor

@tortmayr The Jenkins build is failing, probably because the other change needs to be merged first as there is a problem with the CSS file?

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, there is just one import change that I don't fully understand.

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit 945938f into master May 15, 2024
5 checks passed
@tortmayr tortmayr deleted the issues/1230 branch June 17, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants