Correctly propagate indeterminate progress #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a server reports a progress of -1 (or <=0) we should forward `undefined` to get an indeterminate progress. This is evident with the Java server, which can't easily specify undefined `int`. Change-Id: Ief1395bd5bd56c66cd611238e14557c9f91ed59f
planger
force-pushed
the
planger/issues/1019_fix
branch
from
dc3495d
to
7aad83f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server reports a progress of -1 (or <=0) we should forward
undefinedto get an indeterminate progress. This is evident with the Java server, which can't easily specify undefinedint.eclipse-glsp/glsp#1019