Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default type mappings #97

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix default type mappings #97

merged 1 commit into from
Aug 28, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Aug 28, 2024

What it does

Ensure that the correct type for foreign-object is configure and add missing configuration for GShaprePreRenderedElements

Fixes eclipse-glsp/glsp#1398

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ensure that the correct type for `foreign-object` is configure and add missing
configuration for GShaprePreRenderedElements

Fixes eclipse-glsp/glsp#1398
@tortmayr tortmayr merged commit 757447b into main Aug 28, 2024
6 checks passed
@tortmayr tortmayr deleted the fix-default-mappings branch August 28, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Type mappings configuration is incomplete
2 participants