Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary re-decoration, part of protocol DI import/export #96

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Remove unnecessary re-decoration, part of protocol DI import/export #96

merged 1 commit into from
Aug 22, 2024

Conversation

martin-fleck-at
Copy link
Contributor

@martin-fleck-at martin-fleck-at commented Aug 22, 2024 •
edited
Loading

What it does

Remove unnecessary re-decoration, part of protocol DI import/export
Part of eclipse-glsp/glsp#1381

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

ndoschek
ndoschek approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🎉

@martin-fleck-at martin-fleck-at merged commit cc51d17 into main Aug 22, 2024
6 checks passed
@martin-fleck-at martin-fleck-at deleted the issues/1381 branch August 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndoschek ndoschek ndoschek approved these changes

@tortmayr tortmayr Awaiting requested review from tortmayr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-fleck-at @ndoschek