Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-891: Json operation handler API #59

Merged
merged 1 commit into from
Sep 26, 2023
Merged

GLSP-891: Json operation handler API #59

merged 1 commit into from
Sep 26, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Sep 22, 2023

  • Provides generic,reusable operation handler implementations for JSON-based source models
  • Refactor RecordingCommand API
  • Refactor CreationOperationHandler interfaces to be more strict (Previously it was possible to declare a handler with mixed (nodes/edges) types)
  • Also: Filter out non-critical warning in webpack config

Fixes eclipse-glsp/glsp#891

For testing use: eclipse-glsp/glsp-examples#193

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But requires a test case to be fixed that has duplicate registration.

- Provides  generic,reusable operation handler implementations for JSON-based source models
- Refactor `RecordingCommand` API
- Refactor `CreationOperationHandler` interfaces to be more strict (Previously it was possible to 
  declare a handler with mixed (nodes/edges) types)
Also: Filter out non-critical warning in webpack config
Fixes eclipse-glsp/glsp#891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide generic library for JSON source models
2 participants