Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-960: Improve Diagram container configuration #87

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Sep 4, 2023

Update client and server to consume latest changes for GLPS-960
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282

Update client and server to consume latest changes for GLPS-960
Part of eclipse-glsp/glsp/issues/960
Requires eclipse-glsp/glsp-client#282
@tortmayr tortmayr requested a review from planger September 4, 2023 09:40
@tortmayr
Copy link
Contributor Author

tortmayr commented Sep 4, 2023

Requires lokal linking of the client change
with yarn link @eclipse-glsp/protocol @eclipse-glsp/client sprotty vscode-jsonrpc
(Run the same command with unlink to revert the changes)

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit 362e097 into master Sep 4, 2023
@tortmayr tortmayr deleted the tortmayr/issues/960 branch September 4, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants