Various minor improvements #401
Open
+392
−406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merge *-default.ts implementation files of `FeedbackActionDispatcher` and `HelperLineManager` with the the interface definition files. The split is no longer necessary since we resolved potential circular dependency issues - Ensure that we consistently use the `LazyInjector` over dedicated async providers and deprecate existing provider injection - Fix a bug in the `FocusTracker` where we could end up in an invalid state on startup (diagram active but .diagramElement is undefined). This mostly occurred in standalone contexts (Diagram element is root => no focus change => handle gets never invoked)
martin-fleck-at
requested changes
Nov 25, 2024
| @@ -29,7 +30,7 @@ export interface FocusChange { | |||
| * Allows querying of the current focus state and the focused root diagram element and the currently focused element within the diagram. | |||
| */ | |||
| @injectable() | |||
| export class FocusTracker implements IActionHandler { | |||
| export class FocusTracker implements IActionHandler, IDiagramStartup { | |||
| protected inActiveCssClass = 'inactive'; | |||
| protected _hasFocus = true; | |||
There was a problem hiding this comment.
I wonder if that should really be true now that we actually track the focus change in the beginning?
| postModelInitialization(): MaybePromise<void> { | ||
| this.handleFocusChange(); | ||
| } | ||
|
|
||
| handle(action: Action): void | Action | ICommand { | ||
| if (!FocusStateChangedAction.is(action)) { | ||
| return; | ||
| } | ||
|
|
||
| this._hasFocus = action.hasFocus; |
There was a problem hiding this comment.
This should probably be initialized correctly somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
FeedbackActionDispatcherandHelperLineManagerwith the the interface definition files. The split is no longer necessary since we resolved potential circular dependency issuesLazyInjectorover dedicated async providers and deprecate existing provider injectionFocusTrackerwhere we could end up in an invalid state on startup (diagram active but .diagramElement is undefined). This mostly occurred in standalone contexts (Diagram element is root => no focus change => handle gets never invoked)How to test
Follow-ups
Changelog