GLSP-1399: Fix MousePositionTracker #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the `GLSPMousePositionTracker` correctly calculates the diagram local mouse position
martin-fleck-at
approved these changes
Sep 9, 2024
| @@ -38,9 +29,9 @@ export class GLSPMousePositionTracker extends MousePositionTracker implements Ra | |||
| override mouseMove(target: GModelElement, event: MouseEvent): (Action | Promise<Action>)[] { | |||
| // we cannot simply use the offsetX and offsetY properties of the event since they also consider nested HTML elements | |||
| // such as foreignObjects or the projection bars divs. Instead, we manually translate the client coordinates to the diagram | |||
| const clientToRoot = getAbsoluteClientBounds(target.root, this.domHelper, this.viewerOptions); | |||
There was a problem hiding this comment.
If we change this line, we might also remove the injection of the domHelper and the viewerOptions or is that something you would like to keep for backwards compatibility? I'm a bit unsure because it is only a single method that we are actually providing.
There was a problem hiding this comment.
You are absolutely right. I think we can just remove them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Ensure that the
GLSPMousePositionTrackercorrectly calculates the diagram local mouse positionHow to test
Ensure that resize/move still works as expected.
Also test the corner case with resizing/moving near/over the projection bars
If you want to verify the tracked position you can add a log point in the
GLSPMousePositionTracker.mouseMovemethodFollow-ups
Changelog