Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AbstractTool's accessibleStep mechanism accessible for subclasses #426

Closed
lredor opened this issue Apr 17, 2024 · 0 comments · Fixed by #427
Closed

Make AbstractTool's accessibleStep mechanism accessible for subclasses #426

lredor opened this issue Apr 17, 2024 · 0 comments · Fixed by #427

Comments

@lredor
Copy link
Contributor

lredor commented Apr 17, 2024

Currently, it's not possible to use the methods "accStepReset()", "accStepIncrement()" and "accGetStep()" in AbstractTool subclasses. The goal of this issue is to make these methods protected to allow its use in a subclass.

The final goal is to use them in a subclass of Sirius for issue 359.
lredor added a commit to lredor/gef-classic that referenced this issue Apr 17, 2024
@lredor
Make AbstractTool's accessibleStep mechanism accessible for
cce1351 
subclasses eclipse-gef#426

Fixes eclipse-gef#426
@lredor lredor mentioned this issue Apr 17, 2024
Merged
@azoitl azoitl assigned ptziegler and unassigned ptziegler Apr 17, 2024
lredor added a commit to lredor/gef-classic that referenced this issue Apr 22, 2024
@lredor
Make AbstractTool's accessibleStep mechanism accessible for
b75f4bc 
subclasses eclipse-gef#426

Fixes eclipse-gef#426
lredor added a commit to lredor/gef-classic that referenced this issue Apr 24, 2024
@lredor
Make AbstractTool's accessibleStep mechanism accessible for
24f9b73 
subclasses eclipse-gef#426

Fixes eclipse-gef#426
azoitl pushed a commit that referenced this issue Apr 24, 2024
@lredor @azoitl
Make AbstractTool's accessibleStep mechanism accessible for
abd2af1 
subclasses #426

Fixes #426
@lredor lredor mentioned this issue Apr 25, 2024
Open
lredor added a commit to eclipse-sirius/sirius-desktop that referenced this issue Apr 25, 2024
@lredor
[376] Remove code now accessible as APIs in GEF
868617a 
This commit removes the code duplicated from GEF as it is now available
as API in GEF (through issue
eclipse-gef/gef-classic#426).

Bug: #376
This was referenced Apr 25, 2024
Open
Closed
lredor added a commit to eclipse-sirius/sirius-desktop that referenced this issue Jun 27, 2024
@lredor
[376] Remove code now accessible as APIs in GEF
dff3f2b 
This commit removes the code duplicated from GEF as it is now available
as API in GEF (through issue
eclipse-gef/gef-classic#426).

Bug: #376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make AbstractTool's accessibleStep mechanism accessible for subclasses #426 lredor/gef-classic
2 participants
@lredor @ptziegler