Features should be (de)serialized by using the EFactory, not Jackson's built-in logic

[hallvard]

I have a model with a custom data type (for LocalDate) and I've implemented corresponding createFromString and convertToString methods in the generated EFactory. To my surprise, I got an Exception saying the java.time.LocalDate type isn't supported (without some extra the Jackson module). Looking at the code, it seems the model's factory isn't used at all. I agree that certain types that are native to JSON (boolean and numbers) can be handled specially, but in general emfjson should use the EFactory like the XML/XMI serialization works.

It should be possible to add an option for supporting both, but IMO the default should be to use the EFactory.

[eneufeld]

Sorry for the delayed reply. We gladly accept a PR for this.

[hallvard]

Eugen, Hope this is (a) good (start): #26 I’ve been careful to avoid changing existing behavior, although EFactory could be used for more cases. Regards, Hallvard From: Eugen Neufeld ***@***.***> Reply to: eclipse-emfcloud/emfjson-jackson ***@***.***> Date: Friday, 18 February 2022 at 15:07 To: eclipse-emfcloud/emfjson-jackson ***@***.***> Cc: Hallvard Trætteberg ***@***.***>, Author ***@***.***> Subject: Re: [eclipse-emfcloud/emfjson-jackson] Features should be (de)serialized by using the EFactory, not Jackson's built-in logic (#15) Sorry for the delayed reply. We gladly accept a PR for this. — Reply to this email directly, view it on GitHub<#15 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADBXI5CZHJG3NW3O3BYYQ3U3ZHDLANCNFSM5D75ZBFQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[maho7791]

Hi all,
we are also interested to get this realized. I have seen the PR #26.
What needs to be done, to get this ready? Maybe find time to help out.
Regards,
Mark

[martin-fleck-at]

@maho7791 We basically miss the support for activating this feature through a dedicated option/annotation, see also PR #26.