Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167 Allow EMF Tests to run in p2 build #264

Merged
merged 1 commit into from
Jan 13, 2023
Merged

#167 Allow EMF Tests to run in p2 build #264

merged 1 commit into from
Jan 13, 2023

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Jan 11, 2023 •
edited
Loading

  • Update to mockito 4.9.0
    • Due to the update of the mockito versions, we are now able to run the emf tests again also in the p2 build
    • New version is not available via orbit, consume missing via org.eclipse.emfcloud.modelserver.tests bundle
    • Add mockito dependency libs to tests bundle
  • If emf.tests are running via p2 the test resources are saved differently, hence let's execute tests on resources in a .temp directory to avoid having git changes on each p2 build.

Resolves #167

@ndoschek ndoschek requested a review from eneufeld January 11, 2023 13:15
eneufeld
eneufeld approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@eneufeld eneufeld self-requested a review January 12, 2023 09:53
@ndoschek ndoschek force-pushed the issues/167 branch 2 times, most recently from ecd7a61 to abf1c02 Compare January 12, 2023 15:36
@ndoschek ndoschek requested a review from eneufeld January 12, 2023 15:36
Base automatically changed from issues/211 to master January 13, 2023 15:00
@ndoschek ndoschek marked this pull request as ready for review January 13, 2023 15:07
@ndoschek
#167 Allow EMF Tests to run in p2 build
0828a42 
- Update to mockito 4.9.0
  - Due to the update of the mockito versions, we are now able to run the emf tests again also in the p2 build
  - New version is not available via orbit, consume missing via org.eclipse.emfcloud.modelserver.tests bundle
  - Add mockito dependency libs to tests bundle
- If emf.tests are running via p2 the test resources are saved differently, hence let's execute tests on resources in a .temp directory to avoid having git changes on each p2 build.

Resolves #167
@ndoschek ndoschek merged commit d4fecec into master Jan 13, 2023
@ndoschek ndoschek deleted the issues/167 branch January 13, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow EMF Tests to run in p2 build
2 participants
@ndoschek @eneufeld