Fix #176, Fix #272: Fix references and update in wfconfig files #275
Conversation
Server: - Quote references to allow spaces in names -- Adapt Xtext grammar to use String instead of FQN -- Ensure proposal provider offers quoted strings -- Adapt examples with quoted strings Client: - Notify wfconfig server on *.coffee changes to correctly update index Signed-off-by: Martin Fleck <[email protected]>
|
@martin-fleck-at looks good If it is complicated I suggest to create a follow up |
|
@eneufeld Just from memory: The "references" in the wfconfig file are not real cross references but rather validated strings. As such the language server does not trigger a re-validation of the wfconfig file because it doesn't know that the string it has comes from the changed .coffee file. I believe we could trigger a build/validation ourselves. However, since that information is not stored by Xtext we would need to track that reference information ourselves. Alternatively we would need to build/validate all wfconfig files if there is a change in a .coffee file just in case one of the files references content from that file. I believe the validation of those files is fast and the files are typically not that large. Still, it wouldn't be the most elegant solution. In any case, I believe it makes sense to track that in a separate task for now as we have the following options: real cross references, string references but tracked reference information, build/validation of all wfconfig files. |
|
Thank you for the reply. I will create a follow up. |
Server:
-- Adapt Xtext grammar to use String instead of FQN
-- Ensure proposal provider offers quoted strings
-- Adapt examples with quoted strings
Client:
Signed-off-by: Martin Fleck [email protected]