Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting elements from the tree sometimes breaks diagram #180

Closed
planger opened this issue Aug 29, 2019 · 3 comments · Fixed by #457
Closed

Deleting elements from the tree sometimes breaks diagram #180

planger opened this issue Aug 29, 2019 · 3 comments · Fixed by #457
Labels
bug Something isn't working
Milestone
0.8.0

Comments

@planger
Copy link
Contributor

planger commented Aug 29, 2019

For instance, delete Preheat from the tree, how the diagram will look like this:
image

Deletion works however for tasks that first have been added. From how the diagram looks like, it seems to be an ID problem (the decision/merge node suddenly has the bounds of a task node) and other nodes switch positions, etc?
@planger planger added the bug Something isn't working label Nov 14, 2019
@eneufeld
Copy link
Contributor

@tortmayr is this a generic glsp issue, or is this a coffee editor specific issue?

@tortmayr
Copy link
Contributor

This is a coffee editor specific issue . I had a quick look at the corresponding action handler. The delete operation is currently not delegated to the modelserver and is instead executed directly on the local resource. This is probably the main cause for this issue.

eneufeld added a commit to eneufeld/coffee-editor that referenced this issue Feb 27, 2020
@eneufeld
Fix GLSP Delete by using the model server
e4fefd0 
- Use ModelServer to delegate delete
- Sort commands by descending index

Fixes eclipse-emfcloud#180
eneufeld added a commit to eneufeld/coffee-editor that referenced this issue Feb 27, 2020
@eneufeld
Fix delete by using the model server
5825726 
- Use ModelServer to delegate GLSP delete
- Sort commands by descending index before sending to model server
- Add support to tree for compoundcommands
- Create correct compoundcommand on tree

Fixes eclipse-emfcloud#180
@eneufeld eneufeld assigned eneufeld and unassigned tortmayr Feb 27, 2020
@eneufeld eneufeld assigned tortmayr and unassigned eneufeld Apr 2, 2020
eneufeld added a commit to eneufeld/coffee-editor that referenced this issue Apr 20, 2020
@eneufeld
Fix delete by using the model server
17c4550 
- Use ModelServer to delegate GLSP delete
- Sort commands by descending index before sending to model server
- Add support to tree for compoundcommands
- Create correct compoundcommand on tree

Fixes eclipse-emfcloud#180
tortmayr pushed a commit to eneufeld/coffee-editor that referenced this issue Apr 27, 2020
@eneufeld @tortmayr
Fix delete by using the model server
886b0a8 
- Use ModelServer to delegate GLSP delete
- Sort commands by descending index before sending to model server
- Add support to tree for compoundcommands
- Create correct compoundcommand on tree

Fixes eclipse-emfcloud#180
@eneufeld eneufeld added this to the Backlog milestone Jul 8, 2020
eneufeld added a commit to eneufeld/coffee-editor that referenced this issue Jul 8, 2020
@eneufeld
Fix delete by using the model server
5fd5ff7 
- Use ModelServer to delegate GLSP delete
- Sort commands by descending index before sending to model server
- Add support to tree for compoundcommands
- Create correct compoundcommand on tree

Fixes eclipse-emfcloud#180
eneufeld added a commit to eneufeld/coffee-editor that referenced this issue Oct 21, 2020
@eneufeld
Fix delete by using the model server
c88d1d6 
- Use ModelServer to delegate GLSP delete
- Sort commands by descending index before sending to model server
- Add support to tree for compoundcommands
- Create correct compoundcommand on tree

Fixes eclipse-emfcloud#180
eneufeld added a commit to eneufeld/coffee-editor that referenced this issue Nov 5, 2020
@eneufeld
Fix delete by using the model server
1a09f23 
- Use ModelServer to delegate GLSP delete
- Sort commands by descending index before sending to model server
- Add support to tree for compoundcommands
- Create correct compoundcommand on tree

Fixes eclipse-emfcloud#180
@sgraband
Copy link
Contributor

I am pretty sure that this is already fixed. At least i cannot reproduce it anymore with #457. So if there a no objections i think we can close this when #457 is merged.

@sgraband sgraband mentioned this issue Sep 22, 2022
Merged
@eneufeld eneufeld modified the milestones: Backlog, 0.8.0 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
4 participants
@planger @eneufeld @tortmayr @sgraband