Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused private field #75

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Remove unused private field #75

merged 1 commit into from
Jan 23, 2023

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Dec 28, 2022 •
edited
Loading

Looks like unused since c70cfaa.

@pzygielo pzygielo marked this pull request as ready for review December 28, 2022 09:56
@jbescos
Copy link
Member

jbescos commented Jan 6, 2023

Can we also remove it from constructors?

@pzygielo
Copy link
Contributor Author

pzygielo commented Jan 6, 2023 •
edited
Loading

In this class - bufferPool is passed to JsonParserImpl I think.

@pzygielo
Copy link
Contributor Author

@jbescos - Have I answered your question? (I might not see the modification you think about.)

Is there any change requested for this PR to be considered?

@jbescos
Copy link
Member

jbescos commented Jan 17, 2023

Yes, thank you.

@jbescos jbescos merged commit 10b8d10 into eclipse-ee4j:master Jan 23, 2023
@pzygielo pzygielo deleted the pool branch January 23, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbescos jbescos jbescos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzygielo @jbescos