Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5308 ambiguous resolution during release of FacesContext when there is more than one implementation of FacesContext known to CDI in bean-discovery-mode=all state #5309

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix #5308 ambiguous resolution during release of FacesContext when there is more than one implementation of FacesContext known to CDI in bean-discovery-mode=all state #5309

merged 1 commit into from
Sep 7, 2023

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Sep 7, 2023

@BalusC
Fix #5308 ambiguous resolution during release of FacesContext when there
ffe1e11 
is more than one implementation of FacesContext known to CDI in
bean-discovery-mode=all state
@arjantijms arjantijms added this to the 4.0.4 milestone Sep 7, 2023
@arjantijms arjantijms added bug Something isn't working 4.0 labels Sep 7, 2023
@arjantijms arjantijms merged commit 479c9cc into 4.0 Sep 7, 2023
2 checks passed
@arjantijms arjantijms deleted the mojarra_issue_5308 branch September 7, 2023 10:51
@scottmarlow
Copy link
Member

scottmarlow commented Sep 7, 2023 •
edited
Loading

I pulled the latest 4.0 branch changes and get a build error locally:

Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar (attach-javadocs) on project jakarta.faces: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1 - /home/smarlow/work/jakarta/mojarra/impl/src/main/java/com/sun/faces/facelets/tag/composite/RetargetedAjaxBehavior.java:33: error: malformed HTML
[ERROR]  * Basically represents <f:ajax> which is retargeted by <cc:clientBehavior> in AjaxHandler and checked in AjaxBehaviorRenderer.
[ERROR]                         ^
[ERROR] /home/smarlow/work/jakarta/mojarra/impl/src/main/java/com/sun/faces/facelets/tag/composite/RetargetedAjaxBehavior.java:33: error: bad use of '>'
[ERROR]  * Basically represents <f:ajax> which is retargeted by <cc:clientBehavior> in AjaxHandler and checked in AjaxBehaviorRenderer.
[ERROR]                                ^
[ERROR] /home/smarlow/work/jakarta/mojarra/impl/src/main/java/com/sun/faces/facelets/tag/composite/RetargetedAjaxBehavior.java:33: error: malformed HTML
[ERROR]  * Basically represents <f:ajax> which is retargeted by <cc:clientBehavior> in AjaxHandler and checked in AjaxBehaviorRenderer.
[ERROR]                                                         ^
[ERROR] /home/smarlow/work/jakarta/mojarra/impl/src/main/java/com/sun/faces/facelets/tag/composite/RetargetedAjaxBehavior.java:33: error: bad use of '>'
[ERROR]  * Basically represents <f:ajax> which is retargeted by <cc:clientBehavior> in AjaxHandler and checked in AjaxBehaviorRenderer.

Is anyone else seeing ^ problem?

Updated: I'm working around it with mvn clean install -Dmaven.test.skip=false -Dmaven.javadoc.skip=true (skipping tests is probably not needed but I do that for faster builds :).

@BalusC
Copy link
Contributor Author

BalusC commented Sep 7, 2023

This was coming from 2.3 where it builds fine (and in 3.0). Javadoc lib/settings have apparently changed in 4.0. I will fix it.

@BalusC
Copy link
Contributor Author

BalusC commented Sep 7, 2023

All fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees

@BalusC BalusC

Labels
4.0 bug Something isn't working
Projects
None yet
Milestone
4.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@BalusC @scottmarlow @arjantijms