Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to current state of technology #5167

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Update README to current state of technology #5167

merged 2 commits into from
Nov 13, 2022

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Nov 9, 2022

NicolaIsotta
NicolaIsotta reviewed Nov 10, 2022
View reviewed changes
README.md Outdated
@@ -14,7 +14,7 @@
[//]: # " SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 "
-->

# Mojarra 4.0 WIP
# Mojarra 4.0

Eclipse's implementation of the upcoming Jakarta Faces 4.0 specification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess "upcoming" can be removed?

BalusC
BalusC commented Nov 10, 2022
View reviewed changes
README.md Outdated
@@ -144,7 +144,7 @@ Optionally, register the `FacesServlet` in a Servlet 5.0+ compatible deployment
</web-app>
```

Noted should be that Jakarta Faces 3.0+ is already "implicitly" registered and mapped on `*.jsf`, `*.faces` and `/faces/*` when running on a Jakarta Servlet 5.0+ container. This will be overridden altogether when explicitly registering as above. [The `*.xhtml` URL pattern is preferred over above for security and clarity reasons][17]. Jakarta Faces 2.3+ adds `*.xhtml` to set of default patterns, hence the `FacesServlet` registration being optional. But when you don't explicitly map it on `*.xhtml`, then people can still access JSF pages using `*.jsf`, `*.faces` or `/faces/*` URL patterns. This is not nice for SEO as JSF by design doesn't 301-redirect them to a single mapping.
Noted should be that Jakarta Faces 3.0+ is already "implicitly" registered and mapped on `*.xhtml`, `*.jsf`, `*.faces` and `/faces/*` when running on a Jakarta Servlet 5.0+ container. This will be overridden altogether when explicitly registering as above. [The `*.xhtml` URL pattern is preferred over above for security and clarity reasons][17]. When you don't explicitly map it on `*.xhtml`, then people can still access Faces pages using `*.jsf`, `*.faces` or `/faces/*` URL patterns. This is not nice for SEO as Faces by design doesn't 301-redirect them to a single mapping.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, this should actually say JSF 2.3+ on Servlet 4.0+ as *.xhtml was then introduced as mapping pattern for the first time.

@BalusC BalusC merged commit 2f5a437 into master Nov 13, 2022
@BalusC BalusC deleted the update_README_to_current_state_of_technology branch November 16, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolaIsotta NicolaIsotta NicolaIsotta left review comments

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BalusC @melloware @NicolaIsotta