Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the beanClass attribute of all synth beans points to the CDI extension declaring them #5158

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Make sure the beanClass attribute of all synth beans points to the CDI extension declaring them #5158

merged 3 commits into from
Jan 27, 2023

Conversation

manovotn
Copy link
Contributor

Fixes #5157

@manovotn manovotn mentioned this pull request Oct 20, 2022
Merged
@BalusC
Copy link
Contributor

BalusC commented Nov 12, 2022

LGTM but I want to run TCK on this first.

This was referenced Nov 12, 2022
Closed
Merged
@BalusC BalusC changed the base branch from master to 4.0 November 16, 2022 19:54
@BalusC
Copy link
Contributor

BalusC commented Nov 30, 2022 •
edited
Loading

@manovotn can you please merge the PRs on your fork? Only then I can run the TCK. Your fork is namely based off a very old version.

@manovotn
Copy link
Contributor Author

manovotn commented Dec 1, 2022

I am currently away from my PC and won't be back till Mon; I can do it there if it's still needed.
Otherwise, this PR allows edit by maintainers so you should be able to do that as well.

@manovotn
Copy link
Contributor Author

manovotn commented Dec 5, 2022

I've rebased this PR onto current 4.0 branch which is what I filed it against originally.
@BalusC I assume this should also go into master branch?

@BalusC
Copy link
Contributor

BalusC commented Dec 5, 2022 •
edited
Loading

Not necessary. It will be upmerged nonetheless.

@BalusC
Copy link
Contributor

BalusC commented Jan 27, 2023

TCK passed.

@BalusC BalusC merged commit 0d6ec48 into eclipse-ee4j:4.0 Jan 27, 2023
@manovotn manovotn deleted the beanClassAttrCorrection branch January 27, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDI bean attribute beanClass is not used correctly in CDI extension and producers
3 participants
@manovotn @BalusC @arjantijms