Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5120: no need to doublecheck if view exists when invoked via ViewHandler#deriveLogicalViewId() instead of deriveViewId() #5121

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Fix #5120: no need to doublecheck if view exists when invoked via ViewHandler#deriveLogicalViewId() instead of deriveViewId() #5121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b010a8a
Fix #5120: no need to doublecheck if view exists when invoked via
BalusC Jun 19, 2022
e852770
Update MultiViewHandler.java
arjantijms Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions impl/src/main/java/com/sun/faces/application/view/MultiViewHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,14 +503,7 @@ protected String convertViewId(FacesContext context, String viewId) {

appendOrReplaceExtension(viewId, ext, length, extIdx, buffer);

String convertedViewId = buffer.toString();

ViewDeclarationLanguage vdl = getViewDeclarationLanguage(context, convertedViewId);

if (vdl.viewExists(context, convertedViewId)) {
// RELEASE_PENDING (rlubke,driscoll) cache the lookup
return convertedViewId;
}
return buffer.toString();
}

return viewId;
Expand Down