-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSF trying to load DTD over the network #4701
Conversation
4fed0ec
to
4b715a5
Compare
Can modify the change to introduce a context parameter to control this if you prefer. |
@arjantijms could you take a look at this please? |
The code seems fine, but the ECA check fails unfortunately. That has to be fixed before this can be merged. |
Thanks @arjantijms! |
@arjantijms , @spyrkob , |
e92bdd5
to
1153d5e
Compare
Signed-off-by: Moulali Shikalwadi <[email protected]>
The check can't be run on demand, but your force pushing has triggered it again as you might have seen, and now it passes :) |
A tiny tiny comment is that in newer code we usually try to avoid abbreviations that aren't clear by themselves, like "dbf" here. But it's not a blocker. Thanks a bunch for your contribution! |
this pull request should hava a backport to 2.3 branch |
Signed-off-by: Moulali Shikalwadi [email protected]
issue: #4699