Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSF trying to load DTD over the network #4701

Merged
merged 1 commit into from
Jul 2, 2020
Merged

JSF trying to load DTD over the network #4701

merged 1 commit into from
Jul 2, 2020

Conversation

moulalis
Copy link
Contributor

@moulalis moulalis commented Apr 27, 2020 •
edited
Loading

Signed-off-by: Moulali Shikalwadi [email protected]

issue: #4699

@moulalis moulalis changed the title [4699] JSF trying to load DTD over the network [issue 4699] JSF trying to load DTD over the network Apr 28, 2020
@moulalis moulalis mentioned this pull request Apr 28, 2020
Closed
@moulalis moulalis force-pushed the 4699 branch 2 times, most recently from 4fed0ec to 4b715a5 Compare April 29, 2020 08:09
This was referenced Apr 30, 2020
Closed
Closed
Open
@moulalis
Copy link
Contributor Author

moulalis commented May 4, 2020

Can modify the change to introduce a context parameter to control this if you prefer.

@spyrkob
Copy link
Contributor

spyrkob commented Jul 1, 2020

@arjantijms could you take a look at this please?

@arjantijms
Copy link
Contributor

could you take a look at this please?

The code seems fine, but the ECA check fails unfortunately. That has to be fixed before this can be merged.

@spyrkob
Copy link
Contributor

spyrkob commented Jul 1, 2020

Thanks @arjantijms!

@moulalis moulalis changed the title [issue 4699] JSF trying to load DTD over the network JSF trying to load DTD over the network Jul 2, 2020
@moulalis moulalis closed this Jul 2, 2020
@moulalis moulalis reopened this Jul 2, 2020
@moulalis
Copy link
Contributor Author

moulalis commented Jul 2, 2020 •
edited
Loading

@arjantijms , @spyrkob ,
I have Singed the ECA. Could you please run ECA check. Let me know if anything else is needed.
Thanks.

@moulalis moulalis force-pushed the 4699 branch 2 times, most recently from e92bdd5 to 1153d5e Compare July 2, 2020 12:17
@arjantijms
Copy link
Contributor

I have Singed the ECA. Could you please run ECA check. Let me know if anything else is needed.

The check can't be run on demand, but your force pushing has triggered it again as you might have seen, and now it passes :)

@arjantijms
Copy link
Contributor

A tiny tiny comment is that in newer code we usually try to avoid abbreviations that aren't clear by themselves, like "dbf" here. But it's not a blocker. Thanks a bunch for your contribution!

@arjantijms arjantijms merged commit 8509da6 into eclipse-ee4j:master Jul 2, 2020
@erickdeoliveiraleal
Copy link

this pull request should hava a backport to 2.3 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moulalis @spyrkob @arjantijms @erickdeoliveiraleal