Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing CTS failure issue in master branch #4384

Merged
merged 1 commit into from
May 15, 2018
Merged

fixing CTS failure issue in master branch #4384

merged 1 commit into from
May 15, 2018

Conversation

ren-zhijun-oracle
Copy link
Contributor

No description provided.

ruolli
ruolli approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@ruolli ruolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix was tested already, approve it now.

@ren-zhijun-oracle ren-zhijun-oracle merged commit 475c71e into master May 15, 2018
@kguelzau
Copy link
Contributor

kguelzau commented Nov 4, 2020

@ren-zhijun-oracle this seems to be the fix for CVE-2018-14371.
Is it true that also the 2.2.x branch is affected by this vulnerability? The CVE seems to match all versions below 2.3.7:
https://nvd.nist.gov/vuln/detail/CVE-2018-14371/cpes?expandCpeRanges=true

And I can't see that the 2.2.x is affected by the "loc" parameter:
https://github.com/javaserverfaces/mojarra/blob/166d2173544b40dcfe5359d8ecbb5dda9cb53385/jsf-ri/src/main/java/com/sun/faces/application/resource/ResourceManager.java#L590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxiangde liuxiangde liuxiangde approved these changes

@ruolli ruolli ruolli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ren-zhijun-oracle @kguelzau @liuxiangde @ruolli