Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FaceletViewHandlingStrategy handleRenderException log exception before rethrow #5449

Closed
pizzi80 opened this issue May 23, 2024 · 2 comments
Closed

FaceletViewHandlingStrategy handleRenderException log exception before rethrow #5449

pizzi80 opened this issue May 23, 2024 · 2 comments
Milestone
4.0.9

Comments

@pizzi80
Copy link
Contributor

pizzi80 commented May 23, 2024 •
edited
Loading

Describe the bug

FaceletViewHandlingStrategy.handleRenderException line 944

  1. logs the exception at SEVERE Level
  2. then rethow with a custom algorithm

Expected behavior

  1. logs the exception at FINE Level
  2. rethrow it as a FacesException
@BalusC
Copy link
Contributor

BalusC commented Sep 17, 2024

Related: #5404

BalusC added a commit that referenced this issue Sep 17, 2024
@BalusC
Reduce logging level of exception which is already rethrown -- this only
d80db2c 
causes duplicate logs #5449
@BalusC BalusC mentioned this issue Sep 17, 2024
Merged
@BalusC
Copy link
Contributor

BalusC commented Sep 17, 2024

  1. Level is fixed, it indeed caused duplicate logs (as the container by default indeed already deals with it).
  2. Rethrow is correct as it is, so nothing changed there.

BalusC added a commit that referenced this issue Oct 19, 2024
@BalusC
Merge #5449 from 4.0 into 4.1
b961e78
BalusC added a commit that referenced this issue Oct 19, 2024
@BalusC
Merge #5449 from 4.1 into 5.0
9f0db2d
@BalusC BalusC added this to the 4.0.9 milestone Oct 20, 2024
@BalusC BalusC closed this as completed Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.9
Development

No branches or pull requests
2 participants
@BalusC @pizzi80