Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back Performance-optimized version of ComponentSupport.findChildByTagId() #4924

Closed
BalusC opened this issue May 4, 2021 · 2 comments
Closed

Add back Performance-optimized version of ComponentSupport.findChildByTagId() #4924

BalusC opened this issue May 4, 2021 · 2 comments

Comments

@BalusC
Copy link
Contributor

BalusC commented May 4, 2021 •
edited
Loading

#4808 has been reverted for 2.3.15 as per #4922

This needs to be added back but first we need to identify the failing TCK test and replicate the test in Mojarra project.

@arjantijms can you do this? Then I can take a second look at the impl.
@arjantijms
Copy link
Contributor

Yes, I'll look at adding the test in 2.3 first, and then move it to 3.0 and 4.0 as well.

BalusC added a commit that referenced this issue May 16, 2021
@BalusC
#4924 work around for failing TCK test
1b0ee82
BalusC added a commit that referenced this issue May 16, 2021
@BalusC
#4924: work around failing TCK test
d310ad4
@BalusC BalusC mentioned this issue May 16, 2021
Closed
BalusC added a commit that referenced this issue May 16, 2021
@BalusC
#4924: fixed/improved boolean logic
b0b0d5f
BalusC added a commit that referenced this issue May 22, 2021
@BalusC
#4924 fix failing TCK test due to getCurrentPhaseId() returning null
5bf2e2e
@BalusC BalusC mentioned this issue May 22, 2021
Merged
@BalusC
Copy link
Contributor Author

BalusC commented May 23, 2021

Merged and upmerged in 3.0 and 4.0 as well.

77e0e04
7ebc063

@BalusC BalusC closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BalusC @arjantijms