-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExternalContextImpl.encodeWebsocketURL fails behind SSL termination #4527
Comments
Hi @arjantijms! With all due respect, is there any chance this fix is going to make it into the next release? |
Hi, Somewhat catching up on a huge backlog of emails. From a glance this would be in scope indeed, although the code in question is Bauke's area of expertise. I'll provisionally assign this to him. Thanks for the report! |
Hi! Thanks, @arjantijms. @BalusC, could you please have a look? Cheers |
This fix is correct. Can you create PR? |
fix #4527 by considering request URL protocol instead of request schema
Thanks, @arjantijms and @BalusC! |
I have the same error message on a client site, the setup described below is used: |
Hi
I'm using
<f:websocket>
and do get JS error:ExternalContextImpl
usesrequest.getSchema()
to determine the correct protocol, yet that does not work behind a reverse proxy terminating SSL (HTTPS) and forwarding the request via HTTP.Instead, it should use
HttpServletRequest#getRequestURL()
.The text was updated successfully, but these errors were encountered: