-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ClientProperties.PROXY_URI & al in HttpUrlConnector #5091
Conversation
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jnh-connector (JavaNetHttp connector) relates to Jersey 3.1.+ |
3c609e9
to
b258009
Compare
I am going to postpone that connector because I am working in master. After this is merged I will cherry-pick it and add JavaNetHttp for the branch 3.1. |
There is one issue with the system property 'http.nonProxyHosts' in some connectors. Internally every connector has its own client (Apache, Jetty, etc), and it is configured in the constructor of the connector. The proxy is part of this configuration. Then the client is re-used in different requests. 'http.nonProxyHosts' depends on runtime data, because we need to check the current URI of the request in order to enable or disable the proxy, but note that the proxy was already configured before in the constructor. I don't see a good option to address this. In my opinion there are 3: In my opinion we should go for option 1, because option 2 is memory and performance inefficient, and the different implementations can deal with this with no problem because they have access to system properties. |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
core-client/src/main/java/org/glassfish/jersey/client/ClientProperties.java
Outdated
Show resolved
Hide resolved
...nalproperties/src/test/java/org/glassfish/jersey/tests/externalproperties/HttpProxyTest.java
Show resolved
Hide resolved
core-client/src/main/java/org/glassfish/jersey/client/internal/HttpUrlConnector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jorge Bescos Gascon <[email protected]>
eda9489
to
e30f381
Compare
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Relates to #5089
I don't know what is jnh-connector, Jetty?. That connector is probably not implemented in this PR.