-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GSON media #5090
Support GSON media #5090
Conversation
CI build for now fails with technical error. The related issue is filled 1447 |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos Thank you for the PR. The advantage of Gson is the ability to work with org.json.JSONObject. Can you please add a test demonstrating the usage of this json.org API? |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Sure, I have added that in this commit: |
I have tried to submit CQ for org.json. Unfortunately, the license is not compatible with the Eclipse Foundation rules. I am sorry I asked for the additional test for JSONObject, that additional commit needs to go off. Can you please update the PR? |
No worries, I have reverted it |
a602bf5
to
e1e9913
Compare
It looks the build gets hanged after the maven command:
|
This reverts commit 26a7eff. Signed-off-by: Jorge Bescos Gascon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listed CQ is approved. LGTM
media/json-gson/src/main/java/org/glassfish/jersey/gson/internal/JsonGsonAutoDiscoverable.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Support GSON in Jersey