Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For OSGi services lookup use only classes assignable from service class #5051

Merged
merged 3 commits into from
May 4, 2022

Conversation

mmeldo
Copy link
Contributor

@mmeldo mmeldo commented Apr 26, 2022

Closes #5036
Prevent a situation when the provider class cannot be cast to service class by checking if the service class is assignable from the provider class.

Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senivam senivam requested a review from jansupol April 26, 2022 16:32
@senivam senivam requested a review from jansupol May 3, 2022 13:23
@senivam senivam merged commit 8016b92 into eclipse-ee4j:master May 4, 2022
@senivam senivam added this to the 2.36 milestone May 4, 2022
This was referenced Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException if loaded by different class loaders in OSGi runtime
4 participants