-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for having CDI on pure Jersey Client without Jersey Server #4695
Conversation
… dependencies Signed-off-by: jansupol <[email protected]>
*/ | ||
public static void bindProviders(ComponentBag componentBag, | ||
RuntimeType constrainedTo, | ||
Set<Class<?>> registeredClasses, | ||
InjectionManager injectionManager) { | ||
InjectionManager injectionManager, | ||
Collection<ComponentProvider> componentProviders) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this method is public it is possible that it is already referenced by user code. Shouldn't we duplicate this method with previous arguments?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general contract is that an internal package can be a subject of change. But yes, adding an extra method won't hurt.
Signed-off-by: jansupol <[email protected]>
Signed-off-by: jansupol [email protected]