Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JerseyInvocation should override toString() #4442

Merged
merged 1 commit into from
May 11, 2020
Merged

JerseyInvocation should override toString() #4442

merged 1 commit into from
May 11, 2020

Conversation

thomasmey
Copy link

Override toString() with a sensible implementation.
So if you log a given JerseyInvocation object at least the request method and
URI of the contained requestContext is printed.

See issue #4270

@jansupol
Copy link
Contributor

Please see the wiki.

@thomasmey thomasmey force-pushed the i4270 branch 2 times, most recently from 7409d23 to e9740b1 Compare April 19, 2020 08:13
@jansupol
Copy link
Contributor

Please adjust a copyright year in the file.
Have you thought about using a StringBuilder in the toString method?

@thomasmey
Copy link
Author

Hi,

why use a StringBuilder here?
The JVM seems to optimise this itself anyway to a StringBuilder, the current code is more dense with the same performance:
see also https://stackoverflow.com/a/1532499

@thomasmey
JerseyInvocation should override toString()
91deb4d 
Override toString() with a sensible implementation.
So if you log a given JerseyInvocation object at least the request method and
URI of the contained requestContext is printed.

See issue eclipse-ee4j#4270

Signed-off-by: Thomas Meyer <[email protected]>
@jansupol jansupol merged commit 484e7f6 into eclipse-ee4j:master May 11, 2020
@jansupol jansupol added this to the 2.31 milestone May 11, 2020
This was referenced Jun 26, 2021
Merged
Open
Open
Merged
Open
This was referenced Jul 6, 2021
Merged
Closed
This was referenced Aug 5, 2021
Closed
Closed
This was referenced Aug 30, 2021
Closed
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Sep 6, 2021
Merged
1 task
This was referenced Oct 4, 2021
Merged
Merged
@renovate renovate bot mentioned this pull request Oct 18, 2021
Open
1 task
This was referenced Oct 21, 2021
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Nov 4, 2021
Merged
Closed
@renovate renovate bot mentioned this pull request Jan 10, 2022
Open
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Feb 5, 2022
Closed
1 task
This was referenced Mar 7, 2022
Closed
Closed
This was referenced Mar 15, 2022
Merged
Merged
This was referenced Apr 17, 2022
Closed
Closed
This was referenced May 3, 2022
Open
Open
@renovate renovate bot mentioned this pull request Sep 23, 2022
Merged
1 task
This was referenced Oct 19, 2022
Closed
Closed
@renovate renovate bot mentioned this pull request Feb 11, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 26, 2023
Open
@renovate renovate bot mentioned this pull request May 11, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2023
Open
1 task
@renovate renovate bot mentioned this pull request Aug 30, 2023
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2023
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 11, 2024
Open
This was referenced Apr 13, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@jansupol jansupol jansupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.31
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasmey @jansupol @senivam